fix: hide score on submit + total denominator + projector chart cleanup
Three small UX/fairness tweaks from manual live testing: 1. Post-submit "wait for reveal" screen: show only the response time, no score. The +score reveal leaked correctness — any positive number = correct, zero = wrong — short-circuiting the "stop and think" beat the reveal pause was supposed to enforce. Time stays as the engagement signal; score now waits for the instructor reveal. 2. Final-screen "Correct X / Y" denominator is now total_questions instead of questions_answered. Missed questions are scored zero, so they belong in the denominator visibly. Server adds total_questions to the session_ended payload. 3. Projector score-distribution: drop the in-chart count labels (they collided with each other and with the median tag at small N), restore the previously-computed-but-not-rendered x-axis tick labels at the bottom. Stats line at the foot keeps n / mean / max. Also: short-circuit the per-submit instructor + presence broadcasts when no instructor / projector is connected (no listener, no DB work). The 50-student load test was tight on margin against its 2 s time_limit; with the new presence_message / live_histogram_message DB queries firing on every submit, the margin disappeared on busy boxes. Conftest fixture also bumped to 8 s per question for the same reason — gives breathing room for sequential WS submits in the load test. 71/71 pytest green.
This commit is contained in:
@@ -16,10 +16,14 @@ CANONICAL_SID = "main"
|
||||
|
||||
@pytest.fixture
|
||||
def sample_pool():
|
||||
# 8 s per question gives the load-simulation room to drive 50 sequential
|
||||
# WS submits without the autoclose timer racing them on busy CI / dev
|
||||
# boxes. Tests that don't care about the timer simply close questions
|
||||
# explicitly; the larger default doesn't slow them down.
|
||||
return {
|
||||
"title": "Sample Quiz",
|
||||
"score_fn": "linear_decay",
|
||||
"time_limit_default": 2,
|
||||
"time_limit_default": 8,
|
||||
"session_id": CANONICAL_SID,
|
||||
"questions": [
|
||||
{
|
||||
@@ -27,7 +31,7 @@ def sample_pool():
|
||||
"text": "First question?",
|
||||
"options": {"A": "Alpha", "B": "Beta", "C": "Gamma", "D": "Delta"},
|
||||
"correct": "B",
|
||||
"time_limit": 2,
|
||||
"time_limit": 8,
|
||||
"explanation": "B is correct.",
|
||||
},
|
||||
{
|
||||
@@ -35,28 +39,28 @@ def sample_pool():
|
||||
"text": "Second question?",
|
||||
"options": {"A": "One", "B": "Two", "C": "Three", "D": "Four"},
|
||||
"correct": "C",
|
||||
"time_limit": 2,
|
||||
"time_limit": 8,
|
||||
},
|
||||
{
|
||||
"id": "q3",
|
||||
"text": "Third question?",
|
||||
"options": {"A": "Red", "B": "Blue", "C": "Green", "D": "Gold"},
|
||||
"correct": "A",
|
||||
"time_limit": 2,
|
||||
"time_limit": 8,
|
||||
},
|
||||
{
|
||||
"id": "q4",
|
||||
"text": "Fourth question?",
|
||||
"options": {"A": "North", "B": "South", "C": "East", "D": "West"},
|
||||
"correct": "D",
|
||||
"time_limit": 2,
|
||||
"time_limit": 8,
|
||||
},
|
||||
{
|
||||
"id": "q5",
|
||||
"text": "Fifth question?",
|
||||
"options": {"A": "Fetch", "B": "Decode", "C": "Execute", "D": "Write"},
|
||||
"correct": "A",
|
||||
"time_limit": 1,
|
||||
"time_limit": 8,
|
||||
},
|
||||
],
|
||||
}
|
||||
|
||||
@@ -7,7 +7,7 @@ def test_pool_validation_accepts_well_formed_pool(sample_pool):
|
||||
pool = parse_pool_json(sample_pool)
|
||||
assert pool["title"] == "Sample Quiz"
|
||||
assert pool["score_fn"] == "linear_decay"
|
||||
assert question_time_limit(pool, 0) == 2
|
||||
assert question_time_limit(pool, 0) == 8
|
||||
assert get_question(pool, 0)["correct"] == "B"
|
||||
public = public_question_payload(pool, 0)
|
||||
assert "correct" not in public
|
||||
|
||||
Reference in New Issue
Block a user